Issue 2826020: Fix bug in regexp exec with global regexps.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2826020: Fix bug in regexp exec with global regexps. (Closed)

Created:
10 years, 6 months ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Visibility:
Public.

Description

Fix bug in regexp exec with global regexps.

Patch Set 1 #

Total comments: 1

Patch Set 2 : Addressed review comment. #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+47 lines, -0 lines)			Patch
	M	src/regexp.js	View		1 chunk	+1 line, -0 lines	0 comments	Download
	A	test/mjsunit/regress/regress-45469.js	View	1	1 chunk	+46 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

10 years, 6 months ago (2010-06-25 06:56:14 UTC) #2

LGTM

http://codereview.chromium.org/2826020/diff/1/3
File test/mjsunit/regress/regress-45469.js (right):

http://codereview.chromium.org/2826020/diff/1/3#newcode1
test/mjsunit/regress/regress-45469.js:1: // Copyright 2008 the V8 project
authors. All rights reserved.
2010

Expand Messages | Collapse Messages