Issue 2826014: Allow for a new flag (--log_file) which lets pyauto log to a file instead of ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2826014: Allow for a new flag (--log_file) which lets pyauto log to a file instead of ... (Closed)

Created:
10 years, 6 months ago by alyssad

Modified:
9 years, 7 months ago

Reviewers:
Nirnimesh

CC:
chromium-reviews, Paweł Hajdan Jr.

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

Description

Allow for a new flag (--log_file) which lets pyauto log to a file instead of just stdout. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=50668

Patch Set 3 : '' #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -3 lines)			Patch
	M	chrome/test/pyautolib/pyauto.py	View	1 2	2 chunks	+13 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Nirnimesh

http://codereview.chromium.org/2826014/diff/2001/3001 File chrome/test/pyautolib/pyauto.py (right): http://codereview.chromium.org/2826014/diff/2001/3001#newcode667 chrome/test/pyautolib/pyauto.py:667: '', '--log_file', type='string', default=None, use --log-file http://codereview.chromium.org/2826014/diff/2001/3001#newcode697 chrome/test/pyautolib/pyauto.py:697: filename=self._options.log_file) ...

10 years, 6 months ago (2010-06-23 18:07:02 UTC) #2

alyssad

10 years, 6 months ago (2010-06-23 19:29:03 UTC) #3

LGTM. I'll check this in.

Expand Messages | Collapse Messages

Issue 2826014: Allow for a new flag (--log_file) which lets pyauto log to a file instead of ... (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Messages