Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(996)

Issue 2825077: Update the Native Client DEPS to include r2834 (Closed)

Created:
10 years, 4 months ago by Mark Seaborn
Modified:
9 years, 5 months ago
CC:
chromium-reviews, native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Update the Native Client DEPS This enables the NaCl plugin's async message feature. BUG=50626 TEST=nacl_ui_tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=55048

Patch Set 1 #

Patch Set 2 : Update to fix bug #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Mark Seaborn
General question: is it necessary to run DEPS updates through the Chromium trybot if the ...
10 years, 4 months ago (2010-07-30 16:30:16 UTC) #1
Mark Schneckloth
LGTM In general, I've been running it through the Chromium trybots only because if it ...
10 years, 4 months ago (2010-07-30 17:29:03 UTC) #2
bradn
LGTM On Fri, Jul 30, 2010 at 9:30 AM, <mseaborn@chromium.org> wrote: > Reviewers: Mark Schneckloth, ...
10 years, 4 months ago (2010-07-30 17:34:30 UTC) #3
bradn
10 years, 4 months ago (2010-07-30 17:45:32 UTC) #4
Oh and no I suppose strictly it isn't necessary to run a try job when
rolling into chrome, if the integration builds are green, AND, if you push
to the same revision that they built. (But as msneck says, its good to be
able to point to the trybots if something did go south).

That box isn't actually out of disk, you'll note it says 'invalid file or
disk full'. Its got 36G free.
What's happening is that its gotten to the point where the linker is running
out of memory.
I'm gonna switch boot.ini to /3GB and see if it helps.

-BradN



On Fri, Jul 30, 2010 at 10:33 AM, Bradley Nelson <bradnelson@google.com>wrote:

> LGTM
>
>
> On Fri, Jul 30, 2010 at 9:30 AM, <mseaborn@chromium.org> wrote:
>
>> Reviewers: Mark Schneckloth, bradnelson,
>>
>> Message:
>> General question: is it necessary to run DEPS updates through the Chromium
>> trybot if the NaCl/Chromium integration bot is currently passing?
>>
>> (Although BTW, it is currently *not* passing, mainly because the Windows
>> bot is
>> broken and gives disc space errors.  Brad, can this be fixed by increasing
>> the
>> VM partition size?)
>>
>> The NaCl/Chromium integration bot is actually testing more:  it runs
>> nacl_ui_tests while the Chromium Windows trybot doesn't.
>>
>> Mark
>>
>>
>> Description:
>> Update the Native Client DEPS to include r2834
>>
>> This enables the NaCl plugin's async message feature.
>>
>> BUG=50626
>> TEST=nacl_ui_tests
>>
>> Please review this at http://codereview.chromium.org/2825077/show
>>
>> Affected files:
>>  M DEPS
>>
>>
>> Index: DEPS
>> diff --git a/DEPS b/DEPS
>> index
>>
fdac038fa628bc9633f053b3ef0ded6665623fc4..95222eafb3fd704a60300b4b59e652a0a8fd0a83
>> 100644
>> --- a/DEPS
>> +++ b/DEPS
>> @@ -6,7 +6,7 @@ vars = {
>>   "skia_revision": "592",
>>   "chromium_git": "http://src.chromium.org/git",
>>   "swig_revision": "40423",
>> -  "nacl_revision": "2776",
>> +  "nacl_revision": "2843",
>>   "libvpx_revision": "50313",
>>   "libjingle_revision": "24",
>>  }
>>
>>
>>
>

Powered by Google App Engine
This is Rietveld 408576698