Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 2825076: Actually disable collision-protect in parallel_emerge. (Closed)

Created:
10 years, 4 months ago by davidjames
Modified:
9 years, 4 months ago
Reviewers:
Nick Sanders
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa
Base URL:
ssh://git@chromiumos-git/crosutils.git
Visibility:
Public.

Description

Actually disable collision-protect in parallel_emerge. I tried to disable parallel_emerge yesterday, but my change didn't work, so the buildbots are still running into occasional related issues. Portage has two flags for doing collision protection: collision-protect and protect-owned. The protect-owned feature is enabled by default and is quite useful: it checks to make sure that we don't have multiple packages that own the same file. The collision-protect feature is more strict, and less useful: it fails if it finds a conflicting file, even if that file was created by an earlier ebuild that failed to install. We want to disable collision-protect here because we don't handle failures during the merge step very well -- we just leave the old Unfortunately, we haven't quite figure out the best way to handle these failures in parallel emerge, so for now we disable the flag. TEST=Created a fake collision, made sure that packages still merge. BUG=none

Patch Set 1 #

Total comments: 1

Patch Set 2 : NO TYPOS! #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -3 lines) Patch
M parallel_emerge View 1 2 chunks +14 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
davidjames
10 years, 4 months ago (2010-07-30 06:12:21 UTC) #1
Nick Sanders
10 years, 4 months ago (2010-07-30 06:22:08 UTC) #2
lgtm w/ typo fix

http://codereview.chromium.org/2825076/diff/1/2
File parallel_emerge (right):

http://codereview.chromium.org/2825076/diff/1/2#newcode327
parallel_emerge:327: # Unfortunately, we haven't quite figure out the best way
to handle
typos

Powered by Google App Engine
This is Rietveld 408576698