Simple initial test for AppendCFUserAgentString.

Simple initial test for AppendCFUserAgentString.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52907

[tommi (sloooow) - chröme, 2010-07-16 22:02:48]

lgtm!!  awesome tests strings!

http://codereview.chromium.org/2825053/diff/1/2
File chrome_frame/test/http_negotiate_unittest.cc (right):

http://codereview.chromium.org/2825053/diff/1/2#newcode282
chrome_frame/test/http_negotiate_unittest.cc:282:
testing::ContainsRegex("User-Agent:.+chromeframe.+\r\n"));
indent

http://codereview.chromium.org/2825053/diff/1/2#newcode284
chrome_frame/test/http_negotiate_unittest.cc:284:
EXPECT_THAT(AppendCFUserAgentString(L"Bad User-Agent: Age Tuners;\r\n", NULL),
I need to get me one of those

http://codereview.chromium.org/2825053/diff/1/2#newcode301
chrome_frame/test/http_negotiate_unittest.cc:301: L"Accept-Language: Cleanup a
Cat Egg\r\n"),
hahaha! awesome

[robertshield, 2010-07-16 22:04:49]

http://codereview.chromium.org/2825053/diff/1/2
File chrome_frame/test/http_negotiate_unittest.cc (right):

http://codereview.chromium.org/2825053/diff/1/2#newcode299
chrome_frame/test/http_negotiate_unittest.cc:299: L"Authorization: A Zoo That I
Ruin\r\n"
I have no useful comments other than that this is the coolest CL I have seen in
a long time.

[stoyan, 2010-07-16 22:37:16]

Some anagrams updated, to avoid duplications.

http://codereview.chromium.org/2825053/diff/1/2
File chrome_frame/test/http_negotiate_unittest.cc (right):

http://codereview.chromium.org/2825053/diff/1/2#newcode282
chrome_frame/test/http_negotiate_unittest.cc:282:
testing::ContainsRegex("User-Agent:.+chromeframe.+\r\n"));
On 2010/07/16 22:02:48, tommi wrote:
> indent

Done.

[tommi (sloooow) - chröme, 2010-07-17 01:13:10]

lgtm

http://codereview.chromium.org/2825053/diff/10001/11001
File chrome_frame/test/http_negotiate_unittest.cc (right):

http://codereview.chromium.org/2825053/diff/10001/11001#newcode303
chrome_frame/test/http_negotiate_unittest.cc:303:
AllOf(ContainsRegex("User-Agent: Get a Nurse; chromeframe.+\r\n"),
this one is a duplicate.  I'm confused - did you mean Rat see gun?