chrome/browser/cocoa/location_bar/autocomplete_text_field_cell_unittest.mm - Issue 2825048: [Mac] Allow omnibox decorations to decline mouse events.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/cocoa/location_bar/autocomplete_text_field_cell_unittest.mm

Issue 2825048: [Mac] Allow omnibox decorations to decline mouse events. (Closed) Base URL: git://codf21.jail/chromium.git

Patch Set: Rohit's comment comment, and merge with content-setting change. Created 10 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/cocoa/location_bar/autocomplete_text_field_cell.mm ('k') | chrome/browser/cocoa/location_bar/autocomplete_text_field_unittest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/cocoa/location_bar/autocomplete_text_field_cell_unittest.mm

diff --git a/chrome/browser/cocoa/location_bar/autocomplete_text_field_cell_unittest.mm b/chrome/browser/cocoa/location_bar/autocomplete_text_field_cell_unittest.mm

index d3a4bfd569bd3735a3c1eda35bce3eaf109071bf..6dfa50bdae1d756783dfd7da7a9bd7befe952917 100644

--- a/chrome/browser/cocoa/location_bar/autocomplete_text_field_cell_unittest.mm

+++ b/chrome/browser/cocoa/location_bar/autocomplete_text_field_cell_unittest.mm

@@ -178,6 +178,7 @@ TEST_F(AutocompleteTextFieldCellTest, TextFrame) {

// The cursor frame should stay the same throughout.

const NSRect cursorFrame([cell textCursorFrameForFrame:bounds]);

+ EXPECT_TRUE(NSEqualRects(cursorFrame, bounds));

// At default settings, everything goes to the text area.

textFrame = [cell textFrameForFrame:bounds];

@@ -185,7 +186,7 @@ TEST_F(AutocompleteTextFieldCellTest, TextFrame) {

EXPECT_TRUE(NSContainsRect(bounds, textFrame));

EXPECT_EQ(NSMinX(bounds), NSMinX(textFrame));

EXPECT_EQ(NSMaxX(bounds), NSMaxX(textFrame));

- EXPECT_TRUE(NSEqualRects(cursorFrame, textFrame));

+ EXPECT_TRUE(NSContainsRect(cursorFrame, textFrame));

// Small search hint leaves text frame to left.

[cell setSearchHintString:@"Search hint" availableWidth:kWidth];