[Mac] Allow omnibox decorations to decline mouse events.

[Mac] Allow omnibox decorations to decline mouse events.

Certain decorations like the keyword-search bubble let mouse events
fall through to the field, as indicated by an i-beam cursor.  This
change causes decorations next to the text area to be aggregated into
the text-area's cursor rect.

BUG=41612
TEST=Keyword-search bubble shows I-beam cursor.
TEST=Location icon and star and page actions show arrow.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52807

[Scott Hess - ex-Googler, 2010-07-16 19:03:00]

This will conflict with the content-settings change, but I'm OK with that.  I
think it's a reasonable solution to the overall problem, here.

[rohitrao (ping after 24h), 2010-07-16 19:25:01]

LGTM

Per IRC conversation, I would be sad if clicks between decorations caused the
text to select-all.  I would much rather we just ignored them entirely, or maybe
just place the cursor at the beginning/end of the input text.

I think expanding the i-beam rect to include all non-mouse-pressable decorations
will be ok.

http://codereview.chromium.org/2825048/diff/1/3
File chrome/browser/cocoa/location_bar/autocomplete_text_field_cell.h (right):

http://codereview.chromium.org/2825048/diff/1/3#newcode128
chrome/browser/cocoa/location_bar/autocomplete_text_field_cell.h:128: // mouse
clicks themselves.  Keyword-search bubble, for instance.
// Overridden from StyledTextFieldCell.

[Scott Hess - ex-Googler, 2010-07-16 21:39:46]

On 2010/07/16 19:25:01, rohitrao wrote:
> Per IRC conversation, I would be sad if clicks between decorations caused the
> text to select-all.  I would much rather we just ignored them entirely, or
maybe
> just place the cursor at the beginning/end of the input text.

I think making the test a little loose would work, too.  When my fat fingers
click between the decorations, moving the selection is a weird outcome.  The
main concern I have about loosening the click test is interactions with the text
area (like thinking you're going to the text area but actually clicking an
action).

All that said, while good motor control fixes the what-did-I-click problem, it
couldn't address the flashing-cursor problem :-).

Thanks for the expedient review!

http://codereview.chromium.org/2825048/diff/1/3
File chrome/browser/cocoa/location_bar/autocomplete_text_field_cell.h (right):

http://codereview.chromium.org/2825048/diff/1/3#newcode128
chrome/browser/cocoa/location_bar/autocomplete_text_field_cell.h:128: // mouse
clicks themselves.  Keyword-search bubble, for instance.
On 2010/07/16 19:25:01, rohitrao wrote:
> // Overridden from StyledTextFieldCell.

Done.