build_image: pull out kernel partition creation

build_image: pull out kernel partition creation

Makes kernel partition creation standalone.  This is motivated
both by the ability to build test kernel partitions easily as well
the need to create all kernel command line configuration after the
rootfs has been completely created.

Instead of a massive overhaul, I'll do this refactor in pieces.

TEST=manually rebuilt the image
BUG=chromium-os:327

[Bill Richardson, 2010-06-24 18:00:05]

One nit, but LGTM.

http://codereview.chromium.org/2825021/diff/1/2
File build_image (right):

http://codereview.chromium.org/2825021/diff/1/2#newcode542
build_image:542: load_kernel_test "${OUTPUT_IMG}"
"${OUTPUT_DIR}/key_alg8.vbpubk"
This uses a temporary file that's now emitted by build_kernel_image.sh. Is that
okay?

[adlr, 2010-06-24 18:07:33]

LGTM if you address Bill's comment

[Will Drewry, 2010-06-24 18:16:26]

Thanks for the quick review.  I'm running build_image now...

http://codereview.chromium.org/2825021/diff/1/2
File build_image (right):

http://codereview.chromium.org/2825021/diff/1/2#newcode542
build_image:542: load_kernel_test "${OUTPUT_IMG}"
"${OUTPUT_DIR}/key_alg8.vbpubk"
On 2010/06/24 18:00:05, Bill Richardson wrote:
> This uses a temporary file that's now emitted by build_kernel_image.sh. Is
that
> okay?

I've made that more explicit with two comments and the --keep_work flag on
build_kernel_image.sh.  Does that look sane?

[Bill Richardson, 2010-06-24 18:35:41]

Yeah, much better. Thanks.


LGTM

[Will Drewry, 2010-06-24 19:27:51]

On 2010/06/24 18:35:41, Bill Richardson wrote:
> Yeah, much better. Thanks.
> 
> 
> LGTM

Built fine - testing a boot now before pushing