Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2825008: Move definition of NegateConditon from assembler*-inl.h files to... (Closed)

Created:
10 years, 6 months ago by Mads Ager (chromium)
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Move definition of NegateConditon from assembler*-inl.h files to assembler*.h files to make clang happy. There was no reason for having the definition in the -inl.h files in the first place. Committed: http://code.google.com/p/v8/source/detail?r=4888

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -17 lines) Patch
M src/arm/assembler-arm.h View 1 chunk +4 lines, -1 line 0 comments Download
M src/arm/assembler-arm-inl.h View 1 chunk +0 lines, -5 lines 0 comments Download
M src/ia32/assembler-ia32.h View 2 chunks +6 lines, -1 line 0 comments Download
M src/ia32/assembler-ia32-inl.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/x64/assembler-x64.h View 2 chunks +5 lines, -1 line 0 comments Download
M src/x64/assembler-x64-inl.h View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mads Ager (chromium)
10 years, 6 months ago (2010-06-17 08:14:06 UTC) #1
Vyacheslav Egorov (Chromium)
10 years, 6 months ago (2010-06-17 08:18:33 UTC) #2 
LGTM

Powered by Google App Engine
This is Rietveld 408576698