Issue 2824057: Chromeframe user-agent without need of HttpNegotiate patch.

Issue 2824057: Chromeframe user-agent without need of HttpNegotiate patch. (Closed)

Created:
10 years, 5 months ago by stoyan

Modified:
9 years, 7 months ago

Reviewers:
amit, tommi (sloooow) - chröme

CC:
chromium-reviews, amit

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

BUG=47879 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52806

Patch Set 5 : '' #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+246 lines, -79 lines)			Patch
M	chrome_frame/bho.cc	View		2 chunks	+5 lines, -4 lines	0 comments	Download
M	chrome_frame/chrome_active_document.cc	View		1 chunk	+10 lines, -1 line	0 comments	Download
M	chrome_frame/http_negotiate.h	View	1 2 3	2 chunks	+36 lines, -0 lines	0 comments	Download
M	chrome_frame/http_negotiate.cc	View		4 chunks	+95 lines, -68 lines	0 comments	Download
M	chrome_frame/protocol_sink_wrap.h	View		6 chunks	+22 lines, -0 lines	0 comments	Download
M	chrome_frame/protocol_sink_wrap.cc	View	1 2 3	4 chunks	+75 lines, -6 lines	0 comments	Download
M	chrome_frame/urlmon_url_request.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

tommi (sloooow) - chröme

add a unit test for AppendCFUserAgentString? http://codereview.chromium.org/2824057/diff/8002/13003 File chrome_frame/http_negotiate.h (right): http://codereview.chromium.org/2824057/diff/8002/13003#newcode108 chrome_frame/http_negotiate.h:108: LPWSTR* additional_headers); indent ...

10 years, 5 months ago (2010-07-16 18:32:17 UTC) #2

stoyan

http://codereview.chromium.org/2824057/diff/8002/13003 File chrome_frame/http_negotiate.h (right): http://codereview.chromium.org/2824057/diff/8002/13003#newcode108 chrome_frame/http_negotiate.h:108: LPWSTR* additional_headers); On 2010/07/16 18:32:18, tommi wrote: > indent ...

10 years, 5 months ago (2010-07-16 18:35:36 UTC) #3

amit

I like this very much and great to see patches removed :) LGTM with Tommi's ...

10 years, 5 months ago (2010-07-16 19:03:55 UTC) #4

tommi (sloooow) - chröme

10 years, 5 months ago (2010-07-16 20:36:20 UTC) #5

lgtm from me as well

On Fri, Jul 16, 2010 at 3:03 PM, <amit@chromium.org> wrote:

> I like this very much and great to see patches removed :)
> LGTM with Tommi's concerns addressed.
>
>
>
> http://codereview.chromium.org/2824057/show
>

Expand Messages | Collapse Messages