Issue 2824056: Add one more DLL to the DocumentComplete blacklist.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2824056: Add one more DLL to the DocumentComplete blacklist. (Closed)

Created:
10 years, 5 months ago by tommi (sloooow) - chröme

Modified:
9 years, 7 months ago

Reviewers:
amit

CC:
chromium-reviews, amit

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Add one more DLL to the DocumentComplete blacklist. TEST=see bug BUG=44463 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52908

Patch Set 1 #

Patch Set 2 : '' #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	chrome_frame/chrome_active_document.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

amit

10 years, 5 months ago (2010-07-16 17:41:52 UTC) #2

ok

On Fri, Jul 16, 2010 at 10:32 AM, <tommi@chromium.org> wrote:

> Reviewers: amit,
>
> Description:
> Add one more DLL to the DocumentComplete blacklist.
>
> TEST=see bug
> BUG=44463
>
>
> Please review this at http://codereview.chromium.org/2824056/show
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     chrome_frame/chrome_active_document.cc
>
>
> Index: chrome_frame/chrome_active_document.cc
> ===================================================================
> --- chrome_frame/chrome_active_document.cc      (revision 52668)
> +++ chrome_frame/chrome_active_document.cc      (working copy)
> @@ -1280,6 +1280,7 @@
>       { "askbar.dll", 4, 1 },  // biggest troublemaker: 4.1.0.5.
>       { "gbieh.dll", 3, 8 },  // biggest troublemaker: 3.8.14.12
>       { "gbiehcef.dll", 3, 8 },  // biggest troublemaker: 3.8.11.23
> +      { "gbiehUni.dll", 3, 8 },  // Another Banco DLL.
>     };
>
>     for (size_t i = 0; results == CHECK_NOT_DONE &&
>
>
>

Expand Messages | Collapse Messages