Issue 2824054: Build Chromium browser source as part of sync_build_test.sh

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2824054: Build Chromium browser source as part of sync_build_test.sh (Closed)

Created:
10 years, 5 months ago by raymes

Modified:
9 years, 7 months ago

Reviewers:
asharif1, kmixter1, piman

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
ssh://gitrw.chromium.org/crosutils.git

Visibility:
Public.

Description

Build Chromium browser source as part of sync_build_test.sh Added --chrome_root option to sync_build_test.sh which, if specified, builds Chromium browser from source in the directory given.

Patch Set 1 #

Total comments: 2

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -2 lines)			Patch
	M	sync_build_test.sh	View		4 chunks	+16 lines, -2 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

kmixter1

10 years, 5 months ago (2010-07-16 06:08:17 UTC) #3

LGTM with two nits

Thanks for adding this.

http://codereview.chromium.org/2824054/diff/1/2
File sync_build_test.sh (right):

http://codereview.chromium.org/2824054/diff/1/2#newcode84
sync_build_test.sh:84: DEFINE_string chrome_root "" \
abc order

http://codereview.chromium.org/2824054/diff/1/2#newcode132
sync_build_test.sh:132: if [[ ${FLAGS_chrome_root} ]]; then
-n "${FLAGS_chrome_root}"

Expand Messages | Collapse Messages