Issue 2824045: [gcc] Make GCC complain if setjmp/longjmp builtins are encountered.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2824045: [gcc] Make GCC complain if setjmp/longjmp builtins are encountered. (Closed)

Created:
10 years, 5 months ago by pasko-google - do not use

Modified:
9 years, 7 months ago

Reviewers:
eaeltsin

CC:
native-client-reviews_googlegroups.com

Base URL:
ssh://git@chromiumos-git/nacl-toolchain.git

Visibility:
Public.

Description

[gcc] Make GCC complain if setjmp/longjmp builtins are encountered. Redefine the builtins in c-torture/.../builtins.exp to make a lot of c-torture tests pass. This is a dirty way to fix the tests, we will need to enable the builtins to work with glibc once the latter ready. The purpose of this manipulation is to reduce the amount of failing tests in the GCC testsuite and thus make it easier to focus on more interesting failures.

Patch Set 1 #

Patch Set 2 : precommit upload #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -0 lines)			Patch
	M	gcc/gcc/builtins.c	View		2 chunks	+10 lines, -0 lines	0 comments	Download
	M	gcc/gcc/testsuite/gcc.c-torture/execute/builtins/builtins.exp	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

eaeltsin

Is it possible to hack only the testsuite? I'm not sure that changing gcc/builtins.c is ...

10 years, 5 months ago (2010-07-12 17:50:16 UTC) #2

eaeltsin

10 years, 5 months ago (2010-07-13 09:45:10 UTC) #3

LGTM

I still don't like the change. However, better to have this in and change later.

Expand Messages | Collapse Messages