Pull in the French spellcheck dictionary 2-0. This will be landed...

Pull in the French spellcheck dictionary 2-0. This will be landed
after the new 2-0 dictionary becomes live.

BUG=47891, 47007
TEST=SpellCheckTest.SpellCheckText


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52449

[jungshik at Google, 2010-07-13 16:35:07]

This will not be landed until 2-0 dict becomes online.

[laforge, 2010-07-13 16:42:16]

LGTM

On Tue, Jul 13, 2010 at 9:35 AM, <jshin@chromium.org> wrote:

> Reviewers: hbono,
>
> Message:
> This will not be landed until 2-0 dict becomes online.
>
>
> Description:
> Pull in the French spellcheck dictionary 2-0. This will be landed
> after the new 2-0 dictionary becomes live.
>
> BUG=47891,47007
> TEST=SpellCheckTest.SpellCheckText
>
>
> Please review this at http://codereview.chromium.org/2824042/show
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
>  M     DEPS
>  M     chrome/common/spellcheck_common.cc
>
>
> Index: chrome/common/spellcheck_common.cc
> ===================================================================
> --- chrome/common/spellcheck_common.cc  (revision 51721)
> +++ chrome/common/spellcheck_common.cc  (working copy)
> @@ -91,7 +91,7 @@
>     {"hi-IN", "-1-1"},
>     {"tr-TR", "-1-1"},
>     {"et-EE", "-1-1"},
> -    {"fr-FR", "-1-4"},  // To fix a crash, fr dictionary was updated to
> 1.4.
> +    {"fr-FR", "-2-0"}, // Hunspell fr(modern) 3.7 + Chromium delta.
>     {"lt-LT", "-1-3"},
>     {"pl-PL", "-1-3"},
>     {"hu-HU", "-2-0"},
> Index: DEPS
> ===================================================================
> --- DEPS        (revision 51721)
> +++ DEPS        (working copy)
> @@ -37,7 +37,7 @@
>     "/trunk/deps/third_party/icu42@51076",
>
>   "src/third_party/hunspell":
> -   "/trunk/deps/third_party/hunspell128@50872",
> +   "/trunk/deps/third_party/hunspell128@51875",
>
>   "src/third_party/hunspell_dictionaries":
>    "/trunk/deps/third_party/hunspell_dictionaries@50872",
>
>
>

[Hironori Bono, 2010-07-14 01:30:23]

http://codereview.chromium.org/2824042/diff/3001/4002
File DEPS (right):

http://codereview.chromium.org/2824042/diff/3001/4002#newcode43
DEPS:43: "/trunk/deps/third_party/hunspell_dictionaries@50872",
Sorry for the lack of my explanation. The spellchecker dictionaries have been
moved to "deps/third_party/hunspell_dictionaries". Therefore, we need to change
this line instead of hunspell.

[jungshik at Google, 2010-07-14 22:57:22]

http://codereview.chromium.org/2824042/diff/3001/4002
File DEPS (right):

http://codereview.chromium.org/2824042/diff/3001/4002#newcode43
DEPS:43: "/trunk/deps/third_party/hunspell_dictionaries@50872",
On 2010/07/14 01:30:25, hbono wrote:
> Sorry for the lack of my explanation. The spellchecker dictionaries have been
> moved to "deps/third_party/hunspell_dictionaries". Therefore, we need to
change
> this line instead of hunspell.

I knew that and I meant to change that line, but somehow I changed the wrong one
! ;-)

Thank for pointing that out !!

[Hironori Bono, 2010-07-14 23:44:31]

LGTM, (or il me semble tres bien.)

Regards,

Hironori Bono