Issue 2824039: Use the HWID from the firmware as the hardware class, if available.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2824039: Use the HWID from the firmware as the hardware class, if available. (Closed)

Created:
10 years, 5 months ago by petkov

Modified:
9 years, 7 months ago

Reviewers:
Randall Spangler, vb

CC:
chromium-os-reviews_chromium.org, Luigi Semenzato, sosa

Base URL:
ssh://git@chromiumos-git/metrics.git

Visibility:
Public.

Description

Use the HWID from the firmware as the hardware class, if available. BUG=3089 TEST=gmerge'd on device, ran with and without an hwid file.

Patch Set 2 : Fix HWID path. #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+44 lines, -24 lines)			Patch
	M	hardware_class	View	1	1 chunk	+44 lines, -24 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

petkov

I'm not sure if that's the file location of the HWID file. Also, it's important ...

10 years, 5 months ago (2010-06-29 19:10:44 UTC) #1

Randall Spangler

http://codereview.chromium.org/2824039/diff/1/2 File hardware_class (right): http://codereview.chromium.org/2824039/diff/1/2#newcode18 hardware_class:18: readonly HWID_PATH=/sys/bus/acpi/chromehw/hwid /sys/bus/platform/devices/chromeos_acpi/HWID

10 years, 5 months ago (2010-06-29 21:29:46 UTC) #2

petkov

PTAL http://codereview.chromium.org/2824039/diff/1/2 File hardware_class (right): http://codereview.chromium.org/2824039/diff/1/2#newcode18 hardware_class:18: readonly HWID_PATH=/sys/bus/acpi/chromehw/hwid On 2010/06/29 21:29:46, Randall Spangler wrote: ...

10 years, 5 months ago (2010-06-29 21:39:35 UTC) #3

petkov

10 years, 5 months ago (2010-06-30 17:03:19 UTC) #5

On 2010/06/29 22:14:20, Randall Spangler wrote:
> LGTM

Thanks for the review. I'm pushing this. Please ensure that different hardware
platforms running Google's firmware have different HWIDs.

Expand Messages | Collapse Messages

Issue 2824039: Use the HWID from the firmware as the hardware class, if available. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Fix HWID path. #

Messages