Issue 2824038: WebKit implementation of <meter> element assumes underlying ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2824038: WebKit implementation of <meter> element assumes underlying ... (Closed)

Created:
10 years, 5 months ago by tkent

Modified:
9 years, 7 months ago

Reviewers:

CC:
chromium-reviews, John Grabowski, dpranke+watch_chromium.org, pam+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

WebKit implementation of <meter> element assumes underlying NSGraphicsContext flipped. But it is not true for TestShell. This change make the graphics context flipped. Note that this will break - LayoutTests/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy.html - LayoutTests/fast/dom/HTMLMeterElement/meter-styles.html - LayoutTests/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo.html because the expectation is wrong. BUG=46989 TEST=LayoutTests/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy.html,LayoutTests/fast/dom/HTMLMeterElement/meter-element.html Patch written by morrita@g Original code review: http://codereview.chromium.org/2799020/show Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51096

Patch Set 1 #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	webkit/tools/test_shell/mac/webwidget_host.mm	View		1 chunk	+1 line, -1 line	0 comments	Download