Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Side by Side Diff: chrome/app/chrome_dll_main.cc

Issue 2824008: Command line flag cleanup. (Closed) Base URL: http://src.chromium.org/git/chromium.git
Patch Set: copyright years Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/chromeos/input_method/candidate_window.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // TODO(port): the ifdefs in here are a first step towards trying to determine 5 // TODO(port): the ifdefs in here are a first step towards trying to determine
6 // the correct abstraction for all the OS functionality required at this 6 // the correct abstraction for all the OS functionality required at this
7 // stage of process initialization. It should not be taken as a final 7 // stage of process initialization. It should not be taken as a final
8 // abstraction. 8 // abstraction.
9 9
10 #include "build/build_config.h" 10 #include "build/build_config.h"
(...skipping 509 matching lines...) Expand 10 before | Expand all | Expand 10 after
520 } 520 }
521 521
522 #if defined(OS_WIN) 522 #if defined(OS_WIN)
523 // Must do this before any other usage of command line! 523 // Must do this before any other usage of command line!
524 if (HasDeprecatedArguments(parsed_command_line.command_line_string())) 524 if (HasDeprecatedArguments(parsed_command_line.command_line_string()))
525 return 1; 525 return 1;
526 #endif 526 #endif
527 527
528 #if defined(OS_POSIX) && !defined(OS_MACOSX) && !defined(OS_CHROMEOS) 528 #if defined(OS_POSIX) && !defined(OS_MACOSX) && !defined(OS_CHROMEOS)
529 // Show the man page on --help or -h. 529 // Show the man page on --help or -h.
530 if (parsed_command_line.HasSwitch("help") || 530 if (parsed_command_line.HasSwitch(switches::kHelp) ||
531 parsed_command_line.HasSwitch("h")) { 531 parsed_command_line.HasSwitch(switches::kHelpShort)) {
532 FilePath binary(parsed_command_line.argv()[0]); 532 FilePath binary(parsed_command_line.argv()[0]);
533 execlp("man", "man", binary.BaseName().value().c_str(), NULL); 533 execlp("man", "man", binary.BaseName().value().c_str(), NULL);
534 PLOG(FATAL) << "execlp failed"; 534 PLOG(FATAL) << "execlp failed";
535 } 535 }
536 #endif 536 #endif
537 537
538 #if defined(OS_POSIX) 538 #if defined(OS_POSIX)
539 // Always ignore SIGPIPE. We check the return value of write(). 539 // Always ignore SIGPIPE. We check the return value of write().
540 CHECK(signal(SIGPIPE, SIG_IGN) != SIG_ERR); 540 CHECK(signal(SIGPIPE, SIG_IGN) != SIG_ERR);
541 #endif // OS_POSIX 541 #endif // OS_POSIX
(...skipping 339 matching lines...) Expand 10 before | Expand all | Expand 10 after
881 881
882 logging::CleanupChromeLogging(); 882 logging::CleanupChromeLogging();
883 883
884 #if defined(OS_MACOSX) && defined(GOOGLE_CHROME_BUILD) 884 #if defined(OS_MACOSX) && defined(GOOGLE_CHROME_BUILD)
885 // TODO(mark): See the TODO(mark) above at InitCrashReporter. 885 // TODO(mark): See the TODO(mark) above at InitCrashReporter.
886 DestructCrashReporter(); 886 DestructCrashReporter();
887 #endif // OS_MACOSX && GOOGLE_CHROME_BUILD 887 #endif // OS_MACOSX && GOOGLE_CHROME_BUILD
888 888
889 return rv; 889 return rv;
890 } 890 }
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/chromeos/input_method/candidate_window.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698