Fix a bug when top level break points fall into the last function in script.

Fix a bug when top level break points fall into the last function in script.

Committed: http://code.google.com/p/v8/source/detail?r=4890

[Søren Thygesen Gjesse, 2010-06-17 07:27:14]

LGTM with comments

http://codereview.chromium.org/2824007/diff/1/3
File test/cctest/test-debug.cc (right):

http://codereview.chromium.org/2824007/diff/1/3#newcode2056
test/cctest/test-debug.cc:2056: {
I will suggest that you just call function f and check that no break points are
hit instead of looking up the break point. That will make your test independent
of debugger internals.

http://codereview.chromium.org/2824007/diff/1/3#newcode2078
test/cctest/test-debug.cc:2078: {
Again it think that this should check that running the script caused one break
point to be hit, and running f again will still not cause break points to be
hit.

http://codereview.chromium.org/2824007/diff/1/4
File test/mjsunit/debug-setbreakpoint.js (right):

http://codereview.chromium.org/2824007/diff/1/4#newcode142
test/mjsunit/debug-setbreakpoint.js:142: eval('function sourceUrlFunc()\n{ a =
2; }\n//@ sourceURL=sourceUrlScript');
Why was this change required?

[podivilov, 2010-06-17 12:05:20]

Please review new version of test.

http://codereview.chromium.org/2824007/diff/1/3
File test/cctest/test-debug.cc (right):

http://codereview.chromium.org/2824007/diff/1/3#newcode2056
test/cctest/test-debug.cc:2056: {
On 2010/06/17 07:27:14, Søren Gjesse wrote:
> I will suggest that you just call function f and check that no break points
are
> hit instead of looking up the break point. That will make your test
independent
> of debugger internals.

Done.

http://codereview.chromium.org/2824007/diff/1/3#newcode2078
test/cctest/test-debug.cc:2078: {
On 2010/06/17 07:27:14, Søren Gjesse wrote:
> Again it think that this should check that running the script caused one break
> point to be hit, and running f again will still not cause break points to be
> hit.

Done.

http://codereview.chromium.org/2824007/diff/1/4
File test/mjsunit/debug-setbreakpoint.js (right):

http://codereview.chromium.org/2824007/diff/1/4#newcode142
test/mjsunit/debug-setbreakpoint.js:142: eval('function sourceUrlFunc()\n{ a =
2; }\n//@ sourceURL=sourceUrlScript');
That's because we cannot set a break point on line 1 and fall into function
sourceUrlFunc anymore. Perhaps it's better to fix line number, not eval.

[Søren Thygesen Gjesse, 2010-06-17 12:16:36]

LGTM