Issue 2823034: Ignore if state is CLOSED

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2823034: Ignore if state is CLOSED (Closed)

Created:
10 years, 5 months ago by ukai

Modified:
9 years, 7 months ago

Reviewers:
tyoshino (SeeGerritForStatus), Yuta Kitamura

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org

Visibility:
Public.

Description

Ignore OnConnected event if the job state is already CLOSED. There is a case while SocketStream is connecting, WebSocketJob is closed and SocketStream notifies it is connected. In this case, we should just ignore OnConnected event. BUG=47818 TEST=websocket/tests/url-with-credential.html Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51108

Patch Set 1 #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	net/websockets/websocket_job.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Yuta Kitamura

10 years, 5 months ago (2010-06-29 07:21:22 UTC) #3

LGTM too, but please make change description more descriptive.

Expand Messages | Collapse Messages