Issue 2823025: Fix theme loading bubble which was overstaying its welcome....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2823025: Fix theme loading bubble which was overstaying its welcome.... (Closed)

Created:
10 years, 6 months ago by Miranda Callahan

Modified:
9 years, 7 months ago

Reviewers:
xiyuan

CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, Paul Godavari, pam+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Fix theme loading bubble which was overstaying its welcome. Fixes problem introduced in http://codereview.chromium.org/2659004/show. BUG=46710 TEST=Bring up a regular window, and an incognito window. Install theme from incognito window. Note that loading bubble disappears at the proper time. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=50602

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -3 lines)			Patch
M	chrome/browser/browser.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/download/download_manager.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_install_ui.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2 (0 generated)

LGTM

Thanks for fixing this. :p