Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 2823025: Fix theme loading bubble which was overstaying its welcome.... (Closed)

Created:
10 years, 6 months ago by Miranda Callahan
Modified:
9 years, 7 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, Paul Godavari, pam+watch_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

Fix theme loading bubble which was overstaying its welcome. Fixes problem introduced in http://codereview.chromium.org/2659004/show. BUG=46710 TEST=Bring up a regular window, and an incognito window. Install theme from incognito window. Note that loading bubble disappears at the proper time. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=50602

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/browser/browser.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/download_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_install_ui.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Miranda Callahan
10 years, 6 months ago (2010-06-22 22:16:33 UTC) #1
xiyuan
10 years, 6 months ago (2010-06-22 22:17:40 UTC) #2
LGTM

Thanks for fixing this. :p

Powered by Google App Engine
This is Rietveld 408576698