Issue 2823010: Created wrapper methods for create_base_image and image updates.

Issue 2823010: Created wrapper methods for create_base_image and image updates. (Closed)

Created:
10 years, 6 months ago by dgarrett

Modified:
9 years, 7 months ago

Reviewers:
davidjames, Nick Sanders, sosa

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
ssh://git@chromiumos-git/crosutils.git

Visibility:
Public.

Description

Created wrapper methods for create_base_image and image updates. update_dev_packages, and update_recovery_packages created. Moved assorted global variables up to the top section, since they are global. TEST=Ran build_image. BUG=none

Patch Set 1 #

Patch Set 2 : Fix 80 line problems. #

Patch Set 3 : Correct problem with update_dev_packages. #

Patch Set 4 : Move assorted variables to global section. #

Patch Set 5 : Remove set -x. #

Total comments: 2

Patch Set 6 : Rename developer_cleanup -> mount_gpt_cleanup #

Patch Set 7 : Created wrapper methods for create_base_image and image updates to prepare for --preserve. #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+296 lines, -269 lines)			Patch
	M	build_image	View	1 2 3 4 5	9 chunks	+296 lines, -269 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Nick Sanders

lgtm, below are suggestion only http://codereview.chromium.org/2823010/diff/10001/11001 File build_image (right): http://codereview.chromium.org/2823010/diff/10001/11001#newcode230 build_image:230: # $2 - Directory ...

10 years, 6 months ago (2010-06-18 06:31:44 UTC) #3

sosa

LGTM. On Thu, Jun 17, 2010 at 11:31 PM, <nsanders@chromium.org> wrote: > lgtm, below are ...

10 years, 6 months ago (2010-06-18 17:15:28 UTC) #4

dgarrett

10 years, 6 months ago (2010-06-18 20:53:40 UTC) #5

On 2010/06/18 06:31:44, Nick Sanders wrote:
> lgtm, below are suggestion only
> 
> http://codereview.chromium.org/2823010/diff/10001/11001
> File build_image (right):
> 
> http://codereview.chromium.org/2823010/diff/10001/11001#newcode230
> build_image:230: # $2 - Directory where developer stateful_partition is
mounted.
> Can you rename "overlay_cleanup" or similar?
> 
> http://codereview.chromium.org/2823010/diff/10001/11001#newcode606
> build_image:606: 
> It's likely that factory install, test, factory test images will also move
here
> when the overlay stuff is in, so a common create_mod_image isn't a bad idea


I've uploaded a fix for the first comment.

I agree with the second, but am ignoring it for now.

Expand Messages | Collapse Messages