Issue 28226: Renovate FieldTrial class to better fit with histogram usage.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 28226: Renovate FieldTrial class to better fit with histogram usage. (Closed)

Created:
11 years, 10 months ago by jar (doing other things)

Modified:
9 years, 7 months ago

Reviewers:
Mike Belshe

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Renovate FieldTrial class to better bit with histogram usage. r=mbelshe Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10714

Patch Set 4 : '' #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+235 lines, -46 lines)			Patch
M	base/field_trial.h	View	1 2 3	4 chunks	+121 lines, -21 lines	0 comments	Download
M	base/field_trial.cc	View	1 2 3	3 chunks	+55 lines, -11 lines	0 comments	Download
M	base/field_trial_unittest.cc	View	1 2 3	3 chunks	+59 lines, -14 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mike Belshe

lgtm http://codereview.chromium.org/28226/diff/11/13 File base/field_trial.h (right): http://codereview.chromium.org/28226/diff/11/13#newcode16 Line 16: // randomization (generated randomly once, and then ...

11 years, 9 months ago (2009-03-02 18:42:15 UTC) #2

jar (doing other things)

11 years, 9 months ago (2009-03-02 18:48:56 UTC) #3

Typos filed.  Thanks for the review.

http://codereview.chromium.org/28226/diff/11/13
File base/field_trial.h (right):

http://codereview.chromium.org/28226/diff/11/13#newcode16
Line 16: // randomization (generated randomly once, and then perstently reused
in the
On 2009/03/02 18:42:15, Mike Belshe wrote:
> 'persistently'

Done.

http://codereview.chromium.org/28226/diff/11/12
File base/field_trial_unittest.cc (right):

http://codereview.chromium.org/28226/diff/11/12#newcode73
Line 73: TEST_F(FieldTrialTest, MiddleProbabalities) {
On 2009/03/02 18:42:15, Mike Belshe wrote:
> "MiddleProbabilities"

Done.

Expand Messages | Collapse Messages

Issue 28226: Renovate FieldTrial class to better fit with histogram usage. (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Messages