Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Side by Side Diff: chrome/renderer/render_view.cc

Issue 28224: Revert brett's code, for real this time. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/renderer/about_handler.cc ('k') | chrome/test/automated_ui_tests/automated_ui_tests.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/renderer/render_view.h" 5 #include "chrome/renderer/render_view.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 1589 matching lines...) Expand 10 before | Expand all | Expand 10 after
1600 // treat such cases as browser navigations (in which we will create a new 1600 // treat such cases as browser navigations (in which we will create a new
1601 // renderer for a cross-site navigation), rather than WebKit navigations. 1601 // renderer for a cross-site navigation), rather than WebKit navigations.
1602 // 1602 //
1603 // We use the following heuristic to decide whether to fork a new page in its 1603 // We use the following heuristic to decide whether to fork a new page in its
1604 // own process: 1604 // own process:
1605 // The parent page must open a new tab to about:blank, set the new tab's 1605 // The parent page must open a new tab to about:blank, set the new tab's
1606 // window.opener to null, and then redirect the tab to a cross-site URL using 1606 // window.opener to null, and then redirect the tab to a cross-site URL using
1607 // JavaScript. 1607 // JavaScript.
1608 bool is_fork = 1608 bool is_fork =
1609 // Must start from a tab showing about:blank, which is later redirected. 1609 // Must start from a tab showing about:blank, which is later redirected.
1610 frame->GetURL() == GURL(chrome::kAboutBlankURL) && 1610 frame->GetURL() == GURL("about:blank") &&
1611 // Must be the first real navigation of the tab. 1611 // Must be the first real navigation of the tab.
1612 GetHistoryBackListCount() < 1 && 1612 GetHistoryBackListCount() < 1 &&
1613 GetHistoryForwardListCount() < 1 && 1613 GetHistoryForwardListCount() < 1 &&
1614 // The parent page must have set the child's window.opener to null before 1614 // The parent page must have set the child's window.opener to null before
1615 // redirecting to the desired URL. 1615 // redirecting to the desired URL.
1616 frame->GetOpener() == NULL && 1616 frame->GetOpener() == NULL &&
1617 // Must be a top-level frame. 1617 // Must be a top-level frame.
1618 frame->GetParent() == NULL && 1618 frame->GetParent() == NULL &&
1619 // Must not have issued the request from this page. GetExtraData is NULL 1619 // Must not have issued the request from this page. GetExtraData is NULL
1620 // when the navigation is being done by something outside the page. 1620 // when the navigation is being done by something outside the page.
(...skipping 1362 matching lines...) Expand 10 before | Expand all | Expand 10 after
2983 DCHECK(audio_renderers_.Lookup(stream_id) != NULL); 2983 DCHECK(audio_renderers_.Lookup(stream_id) != NULL);
2984 Send(new ViewHostMsg_SetAudioVolume(routing_id_, stream_id, left, right)); 2984 Send(new ViewHostMsg_SetAudioVolume(routing_id_, stream_id, left, right));
2985 } 2985 }
2986 2986
2987 void RenderView::OnResize(const gfx::Size& new_size, 2987 void RenderView::OnResize(const gfx::Size& new_size,
2988 const gfx::Rect& resizer_rect) { 2988 const gfx::Rect& resizer_rect) {
2989 if (webview()) 2989 if (webview())
2990 webview()->HideAutofillPopup(); 2990 webview()->HideAutofillPopup();
2991 RenderWidget::OnResize(new_size, resizer_rect); 2991 RenderWidget::OnResize(new_size, resizer_rect);
2992 } 2992 }
OLDNEW
« no previous file with comments | « chrome/renderer/about_handler.cc ('k') | chrome/test/automated_ui_tests/automated_ui_tests.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698