Issue 2822044: Set default sync notification method to "server".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2822044: Set default sync notification method to "server". (Closed)

Created:
10 years, 5 months ago by akalin

Modified:
9 years, 7 months ago

Reviewers:
ncarter (slow)

CC:
chromium-reviews, Raghu Simha, ncarter (slow), ben+cc_chromium.org, tim (not reviewing), idana

Visibility:
Public.

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
	M	chrome/browser/sync/notification_method.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download

Total messages: 5 (0 generated)

akalin

+nick for review Will check this in only after server notifications are turned on for ...

10 years, 5 months ago (2010-07-01 23:29:44 UTC) #1

ncarter (slow)

Should you override the default notification method used in LiveSyncTest::SetUpLocalTestServer() as well, so that those ...

10 years, 5 months ago (2010-07-01 23:35:32 UTC) #2

akalin

On 2010/07/01 23:35:32, ncarter wrote: > Should you override the default notification method used in ...

10 years, 5 months ago (2010-07-01 23:43:27 UTC) #3

akalin

10 years, 5 months ago (2010-07-09 18:58:13 UTC) #5

Will re-land this later today.

On 2010/07/02 00:22:59, ncarter wrote:
> Sounds sound.  LGTM.