Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 2822040: Scripts for building Memcheck for OS X Snow Leopard after the merge of... (Closed)

Created:
10 years, 5 months ago by Alexander Potapenko
Modified:
9 years, 6 months ago
Reviewers:
Timur Iskhodzhanov
CC:
chromium-reviews, John Grabowski
Visibility:
Public.

Description

Scripts for building Memcheck for OS X Snow Leopard after the merge of Valgrind's MACOSX106 branch into the Valgrind trunk. BUG=46947 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53625

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -9 lines) Patch
M scripts/build-memcheck-for-chromium.sh View 1 1 chunk +2 lines, -2 lines 0 comments Download
M scripts/common.sh View 1 1 chunk +1 line, -7 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Alexander Potapenko
Timur, I'm not committing this CL because I've only built Snow Leopard binaries using these ...
10 years, 5 months ago (2010-07-01 14:13:06 UTC) #1
Timur Iskhodzhanov
Lgtm 01.07.2010 18:13 пользователь <glider@chromium.org> написал: Reviewers: Timur Iskhodzhanov, Message: Timur, I'm not committing this ...
10 years, 5 months ago (2010-07-02 09:23:36 UTC) #2
Alexander Potapenko
10 years, 5 months ago (2010-07-26 12:46:09 UTC) #3
I've changed the VEX revision to 1987, this should help to fix the bug.

Author: sewardj
Date: 2010-07-23 22:23:25 +0100 (Fri, 23 Jul 2010)
New Revision: 1987

Log:
Support the SSE4 insn 'roundss' in 32-bit mode.  Lack of this was
causing problems for people running 32-bit apps on MacOSX 10.6 on
newer hardware.  Fixes #241377.

Powered by Google App Engine
This is Rietveld 408576698