File API boilerplate.

File API boilerplate.

R=brettw
BUG=41774
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=50939

[brettw, 2010-06-25 20:12:32]

http://codereview.chromium.org/2822031/diff/1/8
File webkit/glue/plugins/pepper_file_ref.cc (right):

http://codereview.chromium.org/2822031/diff/1/8#newcode166
webkit/glue/plugins/pepper_file_ref.cc:166: new FileRef(module(), fs_type_,
path_.substr(0, pos), origin_);
What happens if the input is "/foo"? It seems like pos will be 0 and you'll
generate an empty string which will violate the rule about the leading slash.

[darin (slow to review), 2010-06-25 20:50:46]

Good catch.  Fixed by making the parent path be "/" in that case.
-Darin

On Fri, Jun 25, 2010 at 1:12 PM, <brettw@chromium.org> wrote:

>
> http://codereview.chromium.org/2822031/diff/1/8
> File webkit/glue/plugins/pepper_file_ref.cc (right):
>
> http://codereview.chromium.org/2822031/diff/1/8#newcode166
> webkit/glue/plugins/pepper_file_ref.cc:166: new FileRef(module(),
> fs_type_, path_.substr(0, pos), origin_);
> What happens if the input is "/foo"? It seems like pos will be 0 and
> you'll generate an empty string which will violate the rule about the
> leading slash.
>
>
> http://codereview.chromium.org/2822031/show
>

[darin (slow to review), 2010-06-25 22:37:38]

please take another look
-darin

On Fri, Jun 25, 2010 at 1:50 PM, Darin Fisher <darin@chromium.org> wrote:

> Good catch.  Fixed by making the parent path be "/" in that case.
> -Darin
>
>
> On Fri, Jun 25, 2010 at 1:12 PM, <brettw@chromium.org> wrote:
>
>>
>> http://codereview.chromium.org/2822031/diff/1/8
>> File webkit/glue/plugins/pepper_file_ref.cc (right):
>>
>> http://codereview.chromium.org/2822031/diff/1/8#newcode166
>> webkit/glue/plugins/pepper_file_ref.cc:166: new FileRef(module(),
>> fs_type_, path_.substr(0, pos), origin_);
>> What happens if the input is "/foo"? It seems like pos will be 0 and
>> you'll generate an empty string which will violate the rule about the
>> leading slash.
>>
>>
>> http://codereview.chromium.org/2822031/show
>>
>
>

[brettw, 2010-06-25 22:50:46]

LGTM