Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3531)

Unified Diff: chrome/browser/first_run_mac.mm

Issue 2822026: Mac: First run bubble. (Closed)
Patch Set: '' Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/first_run_mac.mm
diff --git a/chrome/browser/first_run_mac.mm b/chrome/browser/first_run_mac.mm
index 4d2d29fcdd9bf1630949552d6bb78c85eed8ec78..a9c5d21694be70b02794c5de2b99d3e14a0f7b5a 100644
--- a/chrome/browser/first_run_mac.mm
+++ b/chrome/browser/first_run_mac.mm
@@ -70,10 +70,8 @@ FirstRunController::FirstRunController()
void FirstRunController::FirstRunDone() {
// Set preference to show first run bubble and welcome page.
- // TODO(jeremy): Implement
- // FirstRun::SetShowFirstRunBubblePref(true);
- // FirstRun::SetShowWelcomePagePref();
- delete this;
+ FirstRun::SetShowFirstRunBubblePref(true);
+ FirstRun::SetShowWelcomePagePref();
}
bool FirstRunController::DoFirstRun(Profile* profile,
@@ -151,6 +149,9 @@ bool FirstRunController::DoFirstRun(Profile* profile,
ignore_result(gc.release());
StartImportingWithUI(nil, items, importer_host_.get(),
source_profile, profile, this, true);
+ } else {
+ // This is called by the importer if it runs.
+ FirstRunDone();
}
return true;

Powered by Google App Engine
This is Rietveld 408576698