Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Unified Diff: chrome/browser/cocoa/location_bar/location_bar_view_mac.h

Issue 2822026: Mac: First run bubble. (Closed)
Patch Set: '' Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/cocoa/location_bar/location_bar_view_mac.h
diff --git a/chrome/browser/cocoa/location_bar/location_bar_view_mac.h b/chrome/browser/cocoa/location_bar/location_bar_view_mac.h
index f7d77fe7f23685ac20c639a8209a6ff84a9b6f76..6536a95ed99ab8f814edff313dd8c4efafe6d98d 100644
--- a/chrome/browser/cocoa/location_bar/location_bar_view_mac.h
+++ b/chrome/browser/cocoa/location_bar/location_bar_view_mac.h
@@ -47,9 +47,7 @@ class LocationBarViewMac : public AutocompleteEditController,
virtual ~LocationBarViewMac();
// Overridden from LocationBar:
- virtual void ShowFirstRunBubble(FirstRun::BubbleType bubble_type) {
- NOTIMPLEMENTED();
- }
+ virtual void ShowFirstRunBubble(FirstRun::BubbleType bubble_type);
virtual std::wstring GetInputString() const;
virtual WindowOpenDisposition GetWindowOpenDisposition() const;
virtual PageTransition::Type GetPageTransition() const;
@@ -433,6 +431,8 @@ class LocationBarViewMac : public AutocompleteEditController,
// tab contents state.
void RefreshContentSettingsViews();
+ void ShowFirstRunBubbleInternal(FirstRun::BubbleType bubble_type);
+
scoped_ptr<AutocompleteEditViewMac> edit_view_;
CommandUpdater* command_updater_; // Weak, owned by Browser.
@@ -477,6 +477,9 @@ class LocationBarViewMac : public AutocompleteEditController,
// Used to register for notifications received by NotificationObserver.
NotificationRegistrar registrar_;
+ // Used to schedule a task for the first run info bubble.
+ ScopedRunnableMethodFactory<LocationBarViewMac> first_run_bubble_;
+
DISALLOW_COPY_AND_ASSIGN(LocationBarViewMac);
};

Powered by Google App Engine
This is Rietveld 408576698