Issue 2822022: Remove sendMessageToFrontendOnIOThread implementation from test_shell_devtools_agent.cc

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2822022: Remove sendMessageToFrontendOnIOThread implementation from test_shell_devtools_agent.cc (Closed)

Created:
10 years, 6 months ago by mnaganov (inactive)

Modified:
9 years, 7 months ago

Reviewers:
pfeldman, yurys

CC:
chromium-reviews, darin-cc_chromium.org, dpranke+watch_chromium.org, pam+watch_chromium.org

Visibility:
Public.

Description

Remove sendMessageToFrontendOnIOThread implementation from test_shell_devtools_agent.cc BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=50459

Patch Set 1 #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -6 lines)			Patch
	M	webkit/tools/test_shell/test_shell_devtools_agent.cc	View		1 chunk	+0 lines, -6 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

not_yurys

10 years, 6 months ago (2010-06-22 15:17:53 UTC) #2

LGTM

On Tue, Jun 22, 2010 at 7:17 PM,  <mnaganov@chromium.org> wrote:
> Reviewers: Yury Semikhatsky, pfeldman,
>
> Description:
> Remove sendMessageToFrontendOnIOThread implementation from
> test_shell_devtools_agent.cc
>
> BUG=none
> TEST=none
>
> Please review this at http://codereview.chromium.org/2822022/show
>
> Affected files:
>  M webkit/tools/test_shell/test_shell_devtools_agent.cc
>
>
> Index: webkit/tools/test_shell/test_shell_devtools_agent.cc
> diff --git a/webkit/tools/test_shell/test_shell_devtools_agent.cc
> b/webkit/tools/test_shell/test_shell_devtools_agent.cc
> index
>
b692459d67d040cf79295d924c7ba91ee246cbf2..704827db372ca6f460bf308ccdde1ab976567966
> 100644
> --- a/webkit/tools/test_shell/test_shell_devtools_agent.cc
> +++ b/webkit/tools/test_shell/test_shell_devtools_agent.cc
> @@ -162,9 +162,3 @@ bool TestShellDevToolsAgent::evaluateInWebInspector(
>   agent->evaluateInWebInspector(call_id, WebString::fromUTF8(script));
>   return true;
>  }
> -
> -// static
> -void WebKit::WebDevToolsAgentClient::sendMessageToFrontendOnIOThread(
> -    WebKit::WebDevToolsMessageData const &) {
> -  NOTIMPLEMENTED();
> -}
>
>
>

Expand Messages | Collapse Messages