Heap profiler: publish API and add test.

src/profile-generator.cc

 // Copyright 2010 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 1096 matching lines @@
         OS::Print("!!! unknown edge type: %d ", edge->type());
     }
     edge->to()->Print(max_depth, indent + 2);
   }
 }
 
 
 const char* HeapEntry::TypeAsString() {
   switch (type_) {
     case INTERNAL: return "/internal/";
-    case JS_OBJECT: return "/object/";
+    case OBJECT: return "/object/";
     case CLOSURE: return "/closure/";
     case STRING: return "/string/";
     case CODE: return "/code/";
     case ARRAY: return "/array/";
     default: return "???";
   }
 }
 
 
 HeapGraphPath::HeapGraphPath(const List<HeapGraphEdge*>& path)
@@ skipping 127 matching lines @@
 
   // Add new entry.
   if (object->IsJSFunction()) {
     JSFunction* func = JSFunction::cast(object);
     SharedFunctionInfo* shared = func->shared();
     String* name = String::cast(shared->name())->length() > 0 ?
         String::cast(shared->name()) : shared->inferred_name();
     return AddEntry(object, HeapEntry::CLOSURE, collection_->GetName(name));
   } else if (object->IsJSObject()) {
     return AddEntry(object,
-                    HeapEntry::JS_OBJECT,
+                    HeapEntry::OBJECT,
                     collection_->GetName(
                         JSObject::cast(object)->constructor_name()));
   } else if (object->IsJSGlobalPropertyCell()) {
     HeapEntry* value = GetEntry(JSGlobalPropertyCell::cast(object)->value());
     // If GPC references an object that we have interest in, add the object.
     // We don't store HeapEntries for GPCs. Instead, we make our hash map
     // to point to object's HeapEntry by GPCs address.
     if (value != NULL) AddEntryAlias(object, value);
     return value;
   } else if (object->IsString()) {
     return AddEntry(object,
                     HeapEntry::STRING,
                     collection_->GetName(String::cast(object)));
-  } else if (object->IsCode()
-             || object->IsSharedFunctionInfo()
-             || object->IsScript()) {
+  } else if (object->IsCode()) {
     return AddEntry(object, HeapEntry::CODE);
+  } else if (object->IsSharedFunctionInfo()) {
+    SharedFunctionInfo* shared = SharedFunctionInfo::cast(object);
+    String* name = String::cast(shared->name())->length() > 0 ?
+        String::cast(shared->name()) : shared->inferred_name();
+    return AddEntry(object, HeapEntry::CODE, collection_->GetName(name));
+  } else if (object->IsScript()) {
+    Script* script = Script::cast(object);
+    return AddEntry(object,
+                    HeapEntry::CODE,
+                    script->name()->IsString() ?
+                    collection_->GetName(String::cast(script->name())) : "");
   } else if (object->IsFixedArray()) {
     return AddEntry(object, HeapEntry::ARRAY);
   }
   // No interest in this object.
   return NULL;
 }
 
 
 void HeapSnapshot::SetClosureReference(HeapEntry* parent,
                                        String* reference_name,
@@ skipping 303 matching lines @@
         uint32_t index = static_cast<uint32_t>(k->Number());
         snapshot_->SetElementReference(entry, index, dictionary->ValueAt(i));
       }
     }
   }
 }
 
 } }  // namespace v8::internal
 
 #endif  // ENABLE_LOGGING_AND_PROFILING