Run appcache layout tests in chrome using the ui test harness....

Run appcache layout tests in chrome using the ui test harness.

BUG=39365
TEST=yes


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=50798

[michaeln, 2010-06-15 01:28:45]

please take a look

[michaeln, 2010-06-15 01:31:05]

http://codereview.chromium.org/2822007/diff/1/4
File chrome/chrome_tests.gypi (right):

http://codereview.chromium.org/2822007/diff/1/4#newcode293
chrome/chrome_tests.gypi:293: '../webkit/support/webkit_support.gyp:appcache',
oh... this probably doesn't need to be here?

[Paweł Hajdan Jr., 2010-06-15 07:33:08]

Drive-by with a test comment.

http://codereview.chromium.org/2822007/diff/6001/7002
File chrome/browser/appcache/appcache_ui_test.cc (right):

http://codereview.chromium.org/2822007/diff/6001/7002#newcode13
chrome/browser/appcache/appcache_ui_test.cc:13: TEST_F(AppCacheUITest,
FLAKY_AppCacheLayoutTests) {
Why do we start with FLAKY prefix? This is really sad. If you suspect issues
with this test, could you rather split it (similar to how worker tests are done)
so that we can isolate the marks to the specific tests?

[michaeln, 2010-06-15 18:34:41]

> http://codereview.chromium.org/2822007/diff/6001/7002#newcode13
> chrome/browser/appcache/appcache_ui_test.cc:13: TEST_F(AppCacheUITest,
> FLAKY_AppCacheLayoutTests) {
> Why do we start with FLAKY prefix? This is really sad. If you suspect issues
> with this test, could you rather split it (similar to how worker tests are
done)
> so that we can isolate the marks to the specific tests?

Don't be sad :) I just want to watch them for a bit and see what the results
look w/o risking a tree closure. What would make me sad is a tree closure as a
result of adding these tests.

I would really prefer to have each layout tests be in its own test fixture, but
that would mean starting/stopping the test http server for each test which would
be unacceptably slow. I probably should take a look shuffling things around so I
can start the http server once for a number of different test fixtures.
(Many/most worker layout tests don't require starting an http server, those that
do are all bunch up together in a signel fixture).

[Paweł Hajdan Jr., 2010-06-15 18:43:05]

Okay, looks like you know what you're doing. Noted bonus points for mentioning
the plans to monitor test behavior. :) Good luck then. Removing myself from
reviewers.

[jianli, 2010-06-15 19:36:20]

LGTM.