Issue 2822004: Add support for turning on -Wextra on the mac. Doesn't compile that way, but...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2822004: Add support for turning on -Wextra on the mac. Doesn't compile that way, but... (Closed)

Created:
10 years, 6 months ago by TVL

Modified:
9 years, 7 months ago

Reviewers:
Mark Mentovai

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Add support for turning on -Wextra on the mac. Doesn't compile that way, but makes it easier to enable it in a build to start working toward it. BUG=34160 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49785

Patch Set 1 #

Total comments: 1

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -1 line)			Patch
	M	build/common.gypi	View		3 chunks	+15 lines, -1 line	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

10 years, 6 months ago (2010-06-14 19:13:33 UTC) #2

LGTM

http://codereview.chromium.org/2822004/diff/1/2
File build/common.gypi (right):

http://codereview.chromium.org/2822004/diff/1/2#newcode528
build/common.gypi:528: 'WARNING_CFLAGS!': ['-Wall', "-Wextra"],
The adjacent strings use 'single qutoes' instead of "double quotes."

Expand Messages | Collapse Messages