Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 28220: Add some missing files to net.gyp.... (Closed)

Created:
11 years, 10 months ago by eroman
Modified:
9 years, 6 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Add some missing files to net.gyp. This corresponds with <http://codereview.chromium.org/28049>;. BUG=2764 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10526

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add another .h file to list #

Patch Set 3 : move dependency from net_unittests to net #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M net/net.gyp View 1 2 3 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
eroman
My first attempt at modifying the GYP; I am not sure this is right. In ...
11 years, 10 months ago (2009-02-26 22:08:11 UTC) #1
Mark Mentovai
http://codereview.chromium.org/28220/diff/1/2 File net/net.gyp (right): http://codereview.chromium.org/28220/diff/1/2#newcode363 Line 363: '../build/temp_gyp/v8.gyp:v8', This isn't 100% right. If net (the ...
11 years, 10 months ago (2009-02-26 22:12:26 UTC) #2
eroman
Updated, please check again.
11 years, 10 months ago (2009-02-26 22:18:47 UTC) #3
Mark Mentovai
If it builds, it lgtm.
11 years, 10 months ago (2009-02-26 22:20:05 UTC) #4
eroman
11 years, 10 months ago (2009-02-26 22:28:51 UTC) #5
I tested on mac by building:

  net/net_gyp.xcodeproj
  webkit/tools/test_shell/test_shell_gyp.xcodeproj

FYI, gyp is way awesome!

Anecdotally, I spent all of 15 seconds learning gyp (just opened the existing
file and things made sense) in order to make this change.

By comparison, it took me at least an hour to figure out the equivalent steps to
add dependency throughout visual studio, xcode, and scons (and then test them
all).

Powered by Google App Engine
This is Rietveld 408576698