Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issue 28218: Fix scons build where the internal theme files don't exist. (Closed)

Created:
11 years, 10 months ago by tony
Modified:
9 years, 7 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Fix scons build where the internal theme files don't exist.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M tools/grit/grit/scons.py View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
tony
11 years, 10 months ago (2009-02-26 21:30:01 UTC) #1
Lei Zhang
On 2009/02/26 21:30:01, tony wrote: > Is it possible to make the scanner function understand ...
11 years, 10 months ago (2009-02-26 21:44:29 UTC) #2
tony
Yes, I think so. I will try to fix in a follow up, I just ...
11 years, 10 months ago (2009-02-26 21:46:39 UTC) #3
tony
TBR'ing so you can build
11 years, 10 months ago (2009-02-26 21:46:55 UTC) #4
Lei Zhang
11 years, 10 months ago (2009-02-26 21:48:09 UTC) #5
On 2009/02/26 21:46:55, tony wrote:
> TBR'ing so you can build

LGTM
Should I file a bug for this?

Powered by Google App Engine
This is Rietveld 408576698