Issue 28217: Revert "ASCII <-> UTF16 conversion functions. These are just copies of WideToASCII and"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 28217: Revert "ASCII <-> UTF16 conversion functions. These are just copies of WideToASCII and" (Closed)

Created:
11 years, 10 months ago by kuchhal

Modified:
9 years, 7 months ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Revert "ASCII <-> UTF16 conversion functions. These are just copies of WideToASCII and" TBR=darin

Patch Set 1 #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -29 lines)			Patch
	M	base/string_util.h	View		2 chunks	+1 line, -4 lines	0 comments	Download
	M	base/string_util.cc	View		2 chunks	+7 lines, -25 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

kuchhal

11 years, 10 months ago (2009-02-26 21:31:30 UTC) #1

Not entirely sure how but this change seems to be causing all crash_service
dependent ui tests to fail. We will know in 10 minutes if reverting this worked.

Expand Messages | Collapse Messages