Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2721)

Unified Diff: ipc/ipc_channel_posix.cc

Issue 2821028: Up the warnings in ipc (take 2)... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ipc/ipc.gyp ('k') | ipc/ipc_fuzzing_tests.cc » ('j') | ipc/ipc_logging.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ipc/ipc_channel_posix.cc
===================================================================
--- ipc/ipc_channel_posix.cc (revision 53465)
+++ ipc/ipc_channel_posix.cc (working copy)
@@ -699,7 +699,7 @@
// On non-Mac, the Hello message from the client to the server
// also contains the fd_pipe_, which will be used for all
// subsequent file descriptor passing.
- DCHECK_EQ(m.file_descriptor_set()->size(), 1);
+ DCHECK_EQ(m.file_descriptor_set()->size(), 1U);
base::FileDescriptor descriptor;
if (!m.ReadFileDescriptor(&iter, &descriptor)) {
NOTREACHED();
@@ -777,7 +777,7 @@
NOTREACHED();
}
msg = hello.get();
- DCHECK_EQ(msg->file_descriptor_set()->size(), 1);
+ DCHECK_EQ(msg->file_descriptor_set()->size(), 1U);
}
#endif
@@ -853,7 +853,7 @@
if (mode_ != MODE_SERVER && !uses_fifo_ &&
msg->routing_id() == MSG_ROUTING_NONE &&
msg->type() == HELLO_MESSAGE_TYPE) {
- DCHECK_EQ(msg->file_descriptor_set()->size(), 1);
+ DCHECK_EQ(msg->file_descriptor_set()->size(), 1U);
}
if (!uses_fifo_ && !msgh.msg_controllen) {
bytes_written = HANDLE_EINTR(write(pipe_, out_bytes, amt_to_write));
« no previous file with comments | « ipc/ipc.gyp ('k') | ipc/ipc_fuzzing_tests.cc » ('j') | ipc/ipc_logging.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698