Up the warnings in ipc (take 2)...

ipc/ipc_logging.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ipc/ipc_logging.h"
 
 #ifdef IPC_MESSAGE_LOG_ENABLED
 // This will cause render_messages.h etc to define ViewMsgLog and friends.
 #define IPC_MESSAGE_MACROS_LOG_ENABLED
 #endif
@@ skipping 31 matching lines @@
 // all the traits used as IPC message parameters.
 Logging::LogFunction *Logging::log_function_mapping_;
 
 Logging::Logging()
     : enabled_(false),
       enabled_on_stderr_(false),
       queue_invoke_later_pending_(false),
       sender_(NULL),
       main_thread_(MessageLoop::current()),
       consumer_(NULL) {
-  if (getenv("CHROME_IPC_LOGGING")) {
+#if defined(OS_WIN)
+  // getenv triggers an unsafe warning. Simply check how big of a buffer
+  // would be needed to fetch the value to see if the enviornment variable is
+  // set.
+  size_t requiredSize = 0;
+  getenv_s(&requiredSize, NULL, 0, "CHROME_IPC_LOGGING");
+  bool logging_env_var_set = (requiredSize != 0);

[Mark Mentovai, 2010/07/23 15:07:28]

I don’t know if requiredSize will be 0 (or something else) if CHROME_IPC_LOGGING
is set but empty. If it’s set but empty, we should still have
logging_env_var_set true, as in the POSIX case.

[TVL, 2010/07/23 15:26:55]

From what msdn says, if you fetch the value, it will come back with a \0 on the
end. So setting it to no value, will resulting in it needing 1 byte to hold the
string terminator for that empty value.

+#else  // !defined(OS_WIN)
+  bool logging_env_var_set = (getenv("CHROME_IPC_LOGGING") != NULL);

[Mark Mentovai, 2010/07/23 15:07:28]

You could have a const char* just outside the #if to hold the CHROME_IPC_LOGGING
name so that it’s guaranteed the same for both branches of the #if.

+#endif  //defined(OS_WIN)
+  if (logging_env_var_set) {
     enabled_ = true;
     enabled_on_stderr_ = true;
   }
 }
 
 Logging::~Logging() {
 }
 
 Logging* Logging::current() {
   return Singleton<Logging>::get();
@@ skipping 171 matching lines @@
     data->receive = message.received_time();
     data->dispatch = Time::Now().ToInternalValue();
     data->params = params;
     data->message_name = message_name;
   }
 }
 
 }
 
 #endif  // IPC_MESSAGE_LOG_ENABLED