Issue 2821010: Cleanup: Break some common->app dependencies.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2821010: Cleanup: Break some common->app dependencies. (Closed)

Created:
10 years, 6 months ago by Lei Zhang

Modified:
9 years, 7 months ago

Reviewers:
M-A Ruel

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Cleanup: Break some common->app dependencies. BUG=46666 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=50875

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -11 lines)			Patch
M	chrome/app/breakpad_win.h	View	1	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/app/breakpad_win.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/child_process_logging.h	View	1	2 chunks	+9 lines, -1 line	0 comments	Download
M	chrome/common/child_process_logging_linux.cc	View	1	1 chunk	+1 line, -3 lines	0 comments	Download
M	chrome/common/child_process_logging_win.cc	View	1	2 chunks	+1 line, -2 lines	0 comments	Download
M	chrome/common/extensions/extension_action.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 3 (0 generated)

Lei Zhang

On 2010/06/17 23:26:09, Lei Zhang wrote: > Shuffling things around.

10 years, 6 months ago (2010-06-25 05:44:11 UTC) #2

lgtm with BUG=46666 (?)