Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2821010: Cleanup: Break some common->app dependencies. (Closed)

Created:
10 years, 6 months ago by Lei Zhang
Modified:
9 years, 7 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews
Visibility:
Public.

Description

Cleanup: Break some common->app dependencies. BUG=46666 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=50875

Patch Set 1 : '' #

Patch Set 2 : committed version with minor lint cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -11 lines) Patch
M chrome/app/breakpad_win.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/app/breakpad_win.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/child_process_logging.h View 1 2 chunks +9 lines, -1 line 0 comments Download
M chrome/common/child_process_logging_linux.cc View 1 1 chunk +1 line, -3 lines 0 comments Download
M chrome/common/child_process_logging_win.cc View 1 2 chunks +1 line, -2 lines 0 comments Download
M chrome/common/extensions/extension_action.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Lei Zhang
Shuffling things around.
10 years, 6 months ago (2010-06-17 23:26:09 UTC) #1
Lei Zhang
On 2010/06/17 23:26:09, Lei Zhang wrote: > Shuffling things around.
10 years, 6 months ago (2010-06-25 05:44:11 UTC) #2
M-A Ruel
10 years, 6 months ago (2010-06-25 11:38:15 UTC) #3
lgtm with BUG=46666 (?)

Powered by Google App Engine
This is Rietveld 408576698