Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 28206: Fix Linux shared build breakages due to undefined symbols. (Closed)

Created:
11 years, 9 months ago by Michael Moss
Modified:
9 years, 7 months ago
Reviewers:
tony, James Hawkins
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Fix Linux shared build breakages due to undefined symbols.

Patch Set 1 #

Patch Set 2 : rearrange scons file list #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -0 lines) Patch
M chrome/browser/browser.scons View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/views/SConscript View 1 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Michael Moss
This is 1 of 3 to fix shared build. Tony, as we discussed before, when ...
11 years, 9 months ago (2009-02-26 20:06:50 UTC) #1
James Hawkins
I'm OK with this, because at this point we haven't decided how much of views ...
11 years, 9 months ago (2009-02-26 20:38:22 UTC) #2
tony
LGTM On 2009/02/26 20:06:50, mmoss wrote: > This is 1 of 3 to fix shared ...
11 years, 9 months ago (2009-02-26 20:42:40 UTC) #3
tony
Oh, you're removing files. Can you add a comment to these lines that they compile ...
11 years, 9 months ago (2009-02-26 20:51:10 UTC) #4
Michael Moss
Updated.
11 years, 9 months ago (2009-02-26 21:03:36 UTC) #5
James Hawkins
11 years, 9 months ago (2009-02-26 21:05:47 UTC) #6
LGTM

Powered by Google App Engine
This is Rietveld 408576698