Issue 282014: Make drover look a little bit more like the rest of...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 282014: Make drover look a little bit more like the rest of... (Closed)

Created:
11 years, 2 months ago by Nicolas Sylvain

Modified:
9 years, 7 months ago

Reviewers:
laforge

CC:
chromium-reviews_googlegroups.com, M-A Ruel

Base URL:
svn://chrome-svn.corp.google.com/chrome/trunk/tools/depot_tools/

Visibility:
Public.

Description

Make drover look a little bit more like the rest of the python code we have. 90% of the changes are removing trailing spaces. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29312

Patch Set 1 #

Total comments: 1

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+155 lines, -165 lines)			Patch
	M	drover.py	View		14 chunks	+155 lines, -165 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

laforge

11 years, 2 months ago (2009-10-16 14:57:25 UTC) #2

LGTM

Thanks for doing the clean-up.

http://codereview.chromium.org/282014/diff/1/2
File drover.py (right):

http://codereview.chromium.org/282014/diff/1/2#newcode66
Line 66: #TODO(laforge) : Is this correct?
That's correct

Expand Messages | Collapse Messages