Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 2820016: API: Resolve linker issues with using V8 as a DLL... (Closed)

Created:
10 years, 6 months ago by Søren Thygesen Gjesse
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

API: Resolve linker issues with using V8 as a DLL This changes the way the constants kJSObjectType, kFirstNonstringType and kProxyType are made available to the inlined part of the V8 API. This change to fixed constants resolves linker this linker error Windows error LNK2001: unresolved external symbol "public: static int v8::internal::Internals::kJSObjectType" (?kJSObjectType@Internals@internal@v8@@2HA) when linking against a V8 DLL. This change also makes it possible to build all the C++ tests with ENABLE_DEBUGGER_SUPPORT not defined. Now C++ tests run ENABLE_DEBUGGER_SUPPORT not defined, and only the JavaScript tests which tests the debugger fails when ENABLE_DEBUGGER_SUPPORT is not defined. Committed: http://code.google.com/p/v8/source/detail?r=4898

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -11 lines) Patch
M include/v8.h View 1 chunk +3 lines, -5 lines 0 comments Download
M src/api.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/objects.h View 2 chunks +9 lines, -2 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +7 lines, -1 line 0 comments Download
M test/cctest/test-debug.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M test/cctest/test-disasm-ia32.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M test/cctest/test-func-name-inference.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M test/cctest/test-liveedit.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M test/cctest/test-serialize.cc View 5 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Søren Thygesen Gjesse
10 years, 6 months ago (2010-06-18 09:32:44 UTC) #1
Mads Ager (chromium)
10 years, 6 months ago (2010-06-18 09:37:56 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698