Use GetSystemSalt from the cryptohome lib instead of reading salt off disk.

Use GetSystemSalt from the cryptohome lib instead of reading salt off disk.

We used to read the system salt from a file on disk, which meant that
we had to do a bunch of dancing to do some work during login on the
FILE thread instead of the UI thread.  Now, we no longer have to,
because there is an API to request the system's salt value from
cryptohomed over dbus.  This CL is a precursor to some of the other
login/cryptohome changes that are coming.

BUG=chromium-os:323
TEST=unit tests, and loading up a chromium os device and logging in

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49799

[Nikita (slow), 2010-06-15 11:14:49]

LGTM

http://codereview.chromium.org/2820006/diff/1/7
File chrome/browser/chromeos/login/google_authenticator_unittest.cc (right):

http://codereview.chromium.org/2820006/diff/1/7#newcode459
chrome/browser/chromeos/login/google_authenticator_unittest.cc:459:
message_loop.RunAllPending();
Shouldn't these 2 lines be swapped just in case?
Or you want to check that no other URLFetcher is created?

[Chris Masone, 2010-06-15 15:46:28]

pushing...

http://codereview.chromium.org/2820006/diff/1/7
File chrome/browser/chromeos/login/google_authenticator_unittest.cc (right):

http://codereview.chromium.org/2820006/diff/1/7#newcode459
chrome/browser/chromeos/login/google_authenticator_unittest.cc:459:
message_loop.RunAllPending();
On 2010/06/15 11:14:50, Nikita Kostylev wrote:
> Shouldn't these 2 lines be swapped just in case?
> Or you want to check that no other URLFetcher is created?

I do want to enforce that no other URLFetcher is created, yeah