Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Unified Diff: chrome/browser/importer/firefox_importer_utils.cc

Issue 28200: Revert change made in http://codereview.chromium.org/10925.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/importer/firefox_importer_utils.cc
===================================================================
--- chrome/browser/importer/firefox_importer_utils.cc (revision 10482)
+++ chrome/browser/importer/firefox_importer_utils.cc (working copy)
@@ -195,14 +195,12 @@
std::map<std::wstring, TemplateURL*> search_engine_for_url;
std::string content;
- bool need_to_increment_iter;
// The first XML file represents the default search engine in Firefox 3, so we
// need to keep it on top of the list.
TemplateURL* default_turl = NULL;
- for (std::vector<std::wstring>::const_iterator iter = xml_files.begin();
- iter != xml_files.end();) {
- need_to_increment_iter = true;
- file_util::ReadFileToString(*iter, &content);
+ for (std::vector<std::wstring>::const_iterator file_iter = xml_files.begin();
+ file_iter != xml_files.end(); ++file_iter) {
+ file_util::ReadFileToString(*file_iter, &content);
TemplateURL* template_url = new TemplateURL();
FirefoxURLParameterFilter param_filter;
if (TemplateURLParser::Parse(
@@ -218,8 +216,7 @@
// returns a vector with first Firefox default search engines and then
// the user's ones. We want to give priority to the user ones.
delete iter->second;
- iter = search_engine_for_url.erase(iter);
- need_to_increment_iter = false;
+ search_engine_for_url.erase(iter);
}
// Give this a keyword to facilitate tab-to-search, if possible.
template_url->set_keyword(TemplateURLModel::GenerateKeyword(GURL(url),
@@ -232,8 +229,6 @@
delete template_url;
}
content.clear();
- if (need_to_increment_iter)
- ++iter;
}
// Put the results in the |search_engines| vector.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698