Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 28199: Fix incorrect map usage in the WebPluginImpl::didReceiveData function, which ... (Closed)

Created:
11 years, 10 months ago by ananta
Modified:
9 years, 6 months ago
Reviewers:
amit
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Fix incorrect map usage in the WebPluginImpl::didReceiveData function, which caused a response to be incorrectly treated as a multipart response. This would eventually end up sending the ViewHostMsg_DidStopLoading IPC to the browser, which would treat the page as loaded, when it has not. This fixes http://code.google.com/p/chromium/issues/detail?id=7916, which would cause the favicon to not show up on trunk. Bug=7916 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10499

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M webkit/glue/webplugin_impl.cc View 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
ananta
11 years, 10 months ago (2009-02-26 19:02:38 UTC) #1
amit
11 years, 10 months ago (2009-02-26 19:08:20 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698