Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(596)

Issue 28194: Fix grit include dependencies in the scons build. (Closed)

Created:
11 years, 10 months ago by tony
Modified:
9 years, 7 months ago
Reviewers:
Dean McNamee
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Fix grit include dependencies in the scons build. Re-enable the scons code that walks a grd file and adds its dependencies as build dependencies. This requires that all our dependencies are files in our source tree (which is what motivated getting rid of the tld data as a generated resource). I had to fix up the terms of service for this. Also remove some code that disabled .pak file generation on windows which was broken because it couldn't find the tld data.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -19 lines) Patch
M chrome/app/resources/locale_settings.grd View 1 chunk +51 lines, -5 lines 0 comments Download
M tools/grit/grit/scons.py View 1 chunk +4 lines, -5 lines 0 comments Download
M tools/grit/grit/tool/build.py View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
tony
11 years, 10 months ago (2009-02-26 18:39:05 UTC) #1
Dean McNamee
11 years, 10 months ago (2009-02-26 18:40:54 UTC) #2
LG
On 2009/02/26 18:39:05, tony wrote:
>

Powered by Google App Engine
This is Rietveld 408576698