Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 28193: Fix minor error it SDCH filter code (hidden by filter control code)... (Closed)

Created:
11 years, 10 months ago by jar (doing other things)
Modified:
9 years, 7 months ago
Reviewers:
huanr
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Fix minor error it SDCH filter code (hidden by filter control code) The controlling code in filter.cc doesn't significantly distinguish FILTER_OK and FILTER_NEEDS_MORE_DATA, but we *should* transition to a semantic where FILTER_OK becomes instead "FILTER_NEEDS_OUTPUT_SPACE" and then we'd need to do this uniformly for all filter code. We *could* then improve the driving filter code (for example, not have to sniff output buffer usage to deduce that the filter wanted to be called again to emit more data). r=huanr Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10544

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M net/base/sdch_filter.cc View 1 chunk +1 line, -0 lines 1 comment Download

Messages

Total messages: 2 (0 generated)
jar (doing other things)
11 years, 10 months ago (2009-02-26 19:04:50 UTC) #1
huanr
11 years, 10 months ago (2009-02-26 19:08:08 UTC) #2
LGTM

http://codereview.chromium.org/28193/diff/1/2
File net/base/sdch_filter.cc (right):

http://codereview.chromium.org/28193/diff/1/2#newcode255
Line 255: return FILTER_OK;
2 space indent.

Powered by Google App Engine
This is Rietveld 408576698