Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1562)

Unified Diff: chrome/browser/browser_process_impl.cc

Issue 2819092: Reset the notification ui manager even earlier, before the IO thread goes awa... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/browser_process_impl.cc
===================================================================
--- chrome/browser/browser_process_impl.cc (revision 54990)
+++ chrome/browser/browser_process_impl.cc (working copy)
@@ -136,6 +136,10 @@
// Need to clear profiles (download managers) before the io_thread_.
profile_manager_.reset();
+ // Need to clear the desktop notification balloons before the io_thread_,
+ // since if there are any left showing we will post tasks.
+ notification_ui_manager_.reset();
+
// Debugger must be cleaned up before IO thread and NotificationService.
debugger_wrapper_ = NULL;
@@ -193,9 +197,6 @@
// former registers for notifications.
tab_closeable_state_watcher_.reset();
- // Destroy NotificationUIManager before NotificationService is shut down.
- notification_ui_manager_.reset();
-
// Now OK to destroy NotificationService.
main_notification_service_.reset();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698