Issue 2819090: Fix a crash in the history publisher. This is caused by me changing the...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2819090: Fix a crash in the history publisher. This is caused by me changing the... (Closed)

Created:
10 years, 4 months ago by brettw

Modified:
9 years, 7 months ago

Reviewers:
cpu_(ooo_6.6-7.5)

CC:
chromium-reviews, brettw-cc_chromium.org, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fix a crash in the history publisher. This is caused by me changing the signature of ASCIIToWide to no longer take a string piece. This changed the behavior for NULL handling (NULL is no longer supported). This change just doesn't do any conversion if the source is NULL. BUG=51185 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54980

Patch Set 1 #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	chrome/browser/history/history_publisher_win.cc	View		1 chunk	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages