Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5972)

Unified Diff: chrome/browser/extensions/extension_tabs_module.cc

Issue 2819086: Removal of TabContentsDelegate::GetBrowser() interface method (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/extension_install_ui.cc ('k') | chrome/browser/external_tab_container_win.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_tabs_module.cc
===================================================================
--- chrome/browser/extensions/extension_tabs_module.cc (revision 55729)
+++ chrome/browser/extensions/extension_tabs_module.cc (working copy)
@@ -373,7 +373,8 @@
Browser* new_window = new Browser(window_type, window_profile);
new_window->CreateBrowserWindow();
new_window->AddTabWithURL(url, GURL(), PageTransition::LINK, -1,
- TabStripModel::ADD_SELECTED, NULL, std::string());
+ TabStripModel::ADD_SELECTED, NULL, std::string(),
+ &new_window);
new_window->window()->SetBounds(bounds);
new_window->window()->Show();
@@ -581,15 +582,17 @@
TabStripModel::ADD_NONE;
add_types |= TabStripModel::ADD_FORCE_INDEX;
TabContents* contents = browser->AddTabWithURL(url, GURL(),
- PageTransition::LINK, index, add_types, NULL, std::string());
- index = tab_strip->GetIndexOfTabContents(contents);
+ PageTransition::LINK, index, add_types, NULL, std::string(), &browser);
+ index = browser->tabstrip_model()->GetIndexOfTabContents(contents);
if (selected)
contents->Focus();
// Return data about the newly created tab.
if (has_callback())
- result_.reset(ExtensionTabUtil::CreateTabValue(contents, tab_strip, index));
+ result_.reset(ExtensionTabUtil::CreateTabValue(contents,
+ browser->tabstrip_model(),
+ index));
return true;
}
« no previous file with comments | « chrome/browser/extensions/extension_install_ui.cc ('k') | chrome/browser/external_tab_container_win.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698