Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(834)

Unified Diff: chrome/browser/dom_ui/filebrowse_ui.cc

Issue 2819086: Removal of TabContentsDelegate::GetBrowser() interface method (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/dom_ui/dom_ui.cc ('k') | chrome/browser/dom_ui/history2_ui.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/dom_ui/filebrowse_ui.cc
===================================================================
--- chrome/browser/dom_ui/filebrowse_ui.cc (revision 55729)
+++ chrome/browser/dom_ui/filebrowse_ui.cc (working copy)
@@ -751,13 +751,9 @@
} else {
browser = BrowserList::GetLastActive();
}
- TabContents* contents = browser->AddTabWithURL(
- GURL(path), GURL(), PageTransition::LINK, -1,
- TabStripModel::ADD_SELECTED, NULL, std::string());
- // AddTabWithURL could have picked another Browser instance to create this
- // new tab at. So we have to reset the ptr of the browser that we want to
- // talk to.
- browser = contents->delegate()->GetBrowser();
+ browser->AddTabWithURL(GURL(path), GURL(), PageTransition::LINK, -1,
+ TabStripModel::ADD_SELECTED, NULL, std::string(),
+ &browser);
if (popup) {
// TODO(dhg): Remove these from being hardcoded. Allow javascript
// to specify.
@@ -1120,7 +1116,8 @@
browser->AddTabWithURL(
GURL(url), GURL(), PageTransition::LINK, -1,
- TabStripModel::ADD_SELECTED, NULL, std::string());
+ TabStripModel::ADD_SELECTED, NULL, std::string(),
+ &browser);
browser->window()->SetBounds(gfx::Rect(kPopupLeft,
kPopupTop,
width,
« no previous file with comments | « chrome/browser/dom_ui/dom_ui.cc ('k') | chrome/browser/dom_ui/history2_ui.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698